Dark Theme selection highlight now white (Base2) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, like for the color Red, the contrast has been reduced between it, and orange -- so though some additional thought may be required to either redo schemes where red / orange may appear next to one another (such as Ruby). base03 #002B36 - from #000000 base01 #586E75 - from #536871 base00 #657B83 - from #708284|#6a8187 base0 #839496 - from #819090|#899090 base2 #EEE8D5 - from #EAE3CA|#E0EDDD|#EAE3C9 yellow #B58900 - from #A57705|#A57706|#A57800 orange #CB4B16 - from #BB3700|#BD3613|#BD3800|#BF3904 red #DC322F - from #B81D1C|#C60000|#CD1E1D|#D01F1E|#D30102|#D31E1E|#D3201F violet #6C71C4 - from #5A74CF cyan #2AA198 - from #219186|#269186|#469186 green #859900 - from #738A05|#738A13|#748B00 Standard colors from the palette are base03: #002b36 base02: #073642 base01: #586e75 base00: #657b83 base0: #839496 base1: #93a1a1 base2: #eee8d5 base3: #fdf6e3 red: #dc322f magenta: #d33682 violet: #6c71c4 blue: #268bd2 cyan: #2aa198 green: #859900
|
Ah, I believe I screwed up here. But also in light of discussions about TM/Sublime incompatibilities, let's just close this and try again in the Sublime repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #15. This changes seems to match consensus over at altercation/solarized and mirrors the current behaviour of the light theme. Makes selections stand out more which to me seems essential. Just one line, makes all the difference ;)