Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate server to actix-http #224

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

refactor: migrate server to actix-http #224

wants to merge 2 commits into from

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented May 26, 2024

blocked on #226

actix-http is the lower level HTTP lib that powers Actix Web, it's similar in scope/goals to hyper v0.14

pros:

  • –5 LoC
  • we don't need to alter the routing setup
  • we can use automatic HTTP/2 connections from the reverse proxy if we want to

cons:

  • don't get to use the extensive middleware (first- and third-party) selection designed for Actix Web

tokei:

 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 Rust                   30         3947         3391           22          534
 |- Markdown             6           48            0           43            5
 (Total)                           3995         3391           65          539

@robjtede robjtede mentioned this pull request May 26, 2024
@robjtede robjtede changed the base branch from main to tracing May 26, 2024 21:10
@robjtede robjtede force-pushed the actix-http branch 3 times, most recently from 05077ec to f6ba95c Compare May 26, 2024 21:22
@robjtede robjtede changed the title feat: migrate server to actix-http refactor: migrate server to actix-http May 27, 2024
@robjtede robjtede linked an issue May 27, 2024 that may be closed by this pull request
Base automatically changed from tracing to main May 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web server upgrade
1 participant