Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CuteLogger.pri and source build feature #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add CuteLogger.pri and source build feature #21

wants to merge 3 commits into from

Conversation

examyes
Copy link

@examyes examyes commented Jul 19, 2016

  1. move head and source files to CuteLogger.pri.
  2. add macro CUTELOGGER_USE_SRC use to include source files in another project directly

cyberbobs
cyberbobs reviewed Jul 19, 2016
View reviewed changes
include/Logger.h
@@ -71,6 +71,7 @@ CUTELOGGERSHARED_EXPORT Logger* loggerInstance();
class LoggerPrivate;
class CUTELOGGERSHARED_EXPORT Logger
{
private:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is absolutely unnecessary: see issue #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@examyes @cyberbobs