Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] george / WALL-4850 / Password change and account creation success message are not shown when changing password #17318

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

heorhi-deriv
Copy link
Contributor

Changes:

  • Correct the visibility of the password change popup and account creation popup when the user is updating the password for their MT5 account.

Screenshots:

Screen.Recording.2024-10-24.at.15.47.54.mov

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 12, 2024 1:50pm

Copy link
Contributor

github-actions bot commented Oct 24, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17318](https://github.com/deriv-com/deriv-app/pull/17318)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-heorhi-deriv-wall-4850-password-chang-f7fdaf.binary.sx?qa_server=red.derivws.com&app_id=23851
    - **Original**: https://deriv-app-git-fork-heorhi-deriv-wall-4850-password-chang-f7fdaf.binary.sx
- **App ID**: `23851`

Copy link
Contributor

github-actions bot commented Oct 24, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-4850-password-chang-f7fdaf.binary.sx/

@coveralls
Copy link

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11663516665

Details

  • 20 of 44 (45.45%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.8%) to 54.029%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/wallets/src/components/ModalProvider/ModalProvider.tsx 2 3 66.67%
packages/wallets/src/components/WalletsChangeMT5Password/WalletSuccessChangeMT5Password.tsx 9 18 50.0%
packages/wallets/src/features/cfd/modals/MT5PasswordModal/MT5PasswordModal.tsx 1 15 6.67%
Files with Coverage Reduction New Missed Lines %
packages/wallets/src/constants/password.ts 1 93.75%
packages/wallets/src/features/cfd/modals/MT5PasswordModal/MT5PasswordModal.tsx 1 5.76%
Totals Coverage Status
Change from base Build 11662184588: -2.8%
Covered Lines: 35052
Relevant Lines: 60399

💛 - Coveralls

…count-creation-success-message-are-not-shown
jim-deriv
jim-deriv previously approved these changes Oct 28, 2024
nijil-deriv
nijil-deriv previously approved these changes Oct 28, 2024
jim-deriv
jim-deriv previously approved these changes Nov 1, 2024
nijil-deriv
nijil-deriv previously approved these changes Nov 4, 2024
jim-deriv
jim-deriv previously approved these changes Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants