-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WALL] george / WALL-4850 / Password change and account creation success message are not shown when changing password #17318
Open
heorhi-deriv
wants to merge
10
commits into
deriv-com:master
Choose a base branch
from
heorhi-deriv:WALL-4850-Password-change-and-account-creation-success-message-are-not-shown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+174
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heorhi-deriv
requested review from
jim-deriv,
nijil-deriv and
wojciech-deriv
as code owners
October 24, 2024 12:57
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-heorhi-deriv-wall-4850-password-chang-f7fdaf.binary.sx/ |
…on-success-message-are-not-shown
Pull Request Test Coverage Report for Build 11663516665Details
💛 - Coveralls |
lubega-deriv
approved these changes
Oct 25, 2024
…tion-success-message-are-not-shown
heorhi-deriv
had a problem deploying
to
Preview
October 25, 2024 08:53
— with
GitHub Actions
Failure
…count-creation-success-message-are-not-shown
jim-deriv
previously approved these changes
Oct 28, 2024
nijil-deriv
previously approved these changes
Oct 28, 2024
heorhi-deriv
dismissed stale reviews from nijil-deriv and jim-deriv
via
October 30, 2024 13:09
8975015
heorhi-deriv
force-pushed
the
WALL-4850-Password-change-and-account-creation-success-message-are-not-shown
branch
from
October 30, 2024 13:09
8975015
to
4cd1b0f
Compare
heorhi-deriv
had a problem deploying
to
Preview
October 31, 2024 09:34
— with
GitHub Actions
Failure
heorhi-deriv
force-pushed
the
WALL-4850-Password-change-and-account-creation-success-message-are-not-shown
branch
from
October 31, 2024 09:47
83f9987
to
6ea9ecc
Compare
heorhi-deriv
force-pushed
the
WALL-4850-Password-change-and-account-creation-success-message-are-not-shown
branch
from
October 31, 2024 10:31
6ea9ecc
to
792d672
Compare
heorhi-deriv
force-pushed
the
WALL-4850-Password-change-and-account-creation-success-message-are-not-shown
branch
from
October 31, 2024 11:30
cb10c8a
to
6f0308b
Compare
jim-deriv
previously approved these changes
Nov 1, 2024
nijil-deriv
previously approved these changes
Nov 4, 2024
lubega-deriv
approved these changes
Nov 5, 2024
jim-deriv
previously approved these changes
Nov 5, 2024
…tion-success-message-are-not-shown
heorhi-deriv
dismissed stale reviews from jim-deriv and nijil-deriv
via
November 12, 2024 11:15
088251c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Screenshots:
Screen.Recording.2024-10-24.at.15.47.54.mov