Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA]fix: stake error not to be shown when error in only one payout #17491

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vinu-deriv
Copy link
Contributor

Changes:

Fix for stake error not to be shown when error in only one payout and also allow user to save

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 13, 2024 11:35am

Copy link
Contributor

github-actions bot commented Nov 13, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17491](https://github.com/deriv-com/deriv-app/pull/17491)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-vinu-deriv-vinu-dtra-2187fix-stake-error.binary.sx?qa_server=red.derivws.com&app_id=32868
    - **Original**: https://deriv-app-git-fork-vinu-deriv-vinu-dtra-2187fix-stake-error.binary.sx
- **App ID**: `32868`

Copy link
Contributor

github-actions bot commented Nov 13, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-vinu-deriv-vinu-dtra-2187fix-stake-error.binary.sx/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11816072821

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • 199 unchanged lines in 14 files lost coverage.
  • Overall coverage increased (+0.03%) to 53.227%

Files with Coverage Reduction New Missed Lines %
packages/wallets/src/components/DerivAppsSection/DerivAppsGetAccount.tsx 1 89.8%
packages/wallets/src/features/cfd/screens/CompareAccounts/CompareAccountsTitleIcon.tsx 1 95.06%
packages/wallets/src/components/DerivAppsSection/DerivAppsTradingAccount.tsx 2 80.65%
packages/wallets/src/components/OptionsAndMultipliersListing/OptionsAndMultipliersListing.tsx 2 83.67%
packages/wallets/src/features/cfd/components/CFDPlatformsListAccounts/CFDPlatformsListAccounts.tsx 3 56.52%
packages/account/src/Configs/user-profile-validation-config.ts 4 84.0%
packages/wallets/src/features/cfd/constants.tsx 4 74.47%
packages/account/src/Containers/employment-tax-info/employment-tax-info.tsx 5 22.95%
packages/trader/src/AppV2/Components/TradeParameters/Stake/stake.tsx 7 87.84%
packages/account/src/Containers/employment-tax-details-container/employment-tax-details-container.tsx 9 67.4%
Totals Coverage Status
Change from base Build 11793680867: 0.03%
Covered Lines: 32746
Relevant Lines: 57415

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants