-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aswathy/CRO-778/feat: Added the console error tracking for the virtual signup flow #17497
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aswathy-deriv-track-console-error.binary.sx/ |
packages/core/src/App/Containers/AccountSignupModal/account-signup-modal.jsx
Outdated
Show resolved
Hide resolved
const [is_disclaimer_accepted, setIsDisclaimerAccepted] = React.useState(false); | ||
const [is_questionnaire, setIsQuestionnaire] = React.useState(false); | ||
const [ab_questionnaire, setABQuestionnaire] = React.useState(); | ||
const [modded_state, setModdedState] = React.useState({}); | ||
const language = getLanguage(); | ||
|
||
const [is_signup_flow_error] = useGrowthbookGetFeatureValue({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the expected behaviour of this feature flag?
I dont understand it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming is also vague.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's like enable_signup_error_tracking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its like should we enable the signup_flow_error
feature flag or not
⏳ Generating Lighthouse report... |
Changes:
Added the
screen_name
and actionsignup_flow_error
for the eventce_virtual_signup_form
and the error_message from trackjs if there is any error coming in the console for the country_selection and password_selection pageScreenshots:
Please provide some screenshots of the change.