Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTRA-1933 / Kate / Console error fix #17508

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −7
Open

DTRA-1933 / Kate / Console error fix #17508

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a423c66
chore: remove translation from label
kate-deriv Nov 14, 2024
6c00134
chore: remove comment
kate-deriv Nov 14, 2024
eafe592
chore: add brackets
kate-deriv Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions packages/trader/src/AppV2/Components/Filter/contract-type-filter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,14 @@ const ContractTypeFilter = ({ contractTypeFilter, onApplyContractTypeFilter }: T
className='filter__chip'
dropdown
isDropdownOpen={isDropdownOpen}
label={<Localize i18n_default_text='Trade types' key='trade_types_label' />}
onClick={() => setIsDropdownOpen(!isDropdownOpen)}
selected={!!changedOptions.length}
size='md'
>
{!!changedOptions.length && (
<Text>
{/* Chip component throws a missing unique "key" prop error in quill-ui on test links, hence added a key */}
<React.Fragment key='trade_types_count'>({changedOptions.length})</React.Fragment>
</Text>
)}
<Text size='sm'>
<Localize i18n_default_text='Trade types' />
</Text>
{!!changedOptions.length && <Text>({changedOptions.length})</Text>}
</Chip.Standard>
<ActionSheet.Root isOpen={isDropdownOpen} onClose={onActionSheetClose} position='left' expandable={false}>
<ActionSheet.Portal shouldCloseOnDrag>
Expand Down
Loading