Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[WALL] george / WALL-5105 / Remove the jurisdiction information on compare account table for wallets" #17511

Conversation

akmal-deriv
Copy link
Contributor

Reverts #17441

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app 🔄 Building (Inspect) Visit Preview Nov 15, 2024 3:39am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@akmal-deriv akmal-deriv merged commit 9d347e7 into master Nov 15, 2024
4 of 5 checks passed
@akmal-deriv akmal-deriv deleted the revert-17441-COJ-1424-Remove-the-jurisdiction-information-on-compare-account-table-for-wallets branch November 15, 2024 03:57
Copy link
Contributor

package old new diff pct change
account 296 KB 296 KB 0 B 0% 🟢
appstore 290 KB 290 KB 0 B 0% 🟢
bot-web-ui 717 KB 717 KB 0 B 0% 🟢
cashier 595 KB 595 KB 0 B 0% 🟢
cfd 117 KB 117 KB 0 B 0% 🟢
core 6.8 MB 6.8 MB +3 B +0.0% 🟢
p2p 1.1 MB 1.1 MB 0 B 0% 🟢
reports 59 KB 59 KB 0 B 0% 🟢
trader 592 KB 592 KB 0 B 0% 🟢
wallets 877 KB 878 KB +346 B +0.0% 🟢

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11849845757

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 46 of 46 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 53.218%

Files with Coverage Reduction New Missed Lines %
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
packages/trader/src/AppV2/Utils/trade-params-utils.tsx 1 86.8%
Totals Coverage Status
Change from base Build 11820031634: 0.07%
Covered Lines: 32746
Relevant Lines: 57416

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants