-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.14 #44
base: master
Are you sure you want to change the base?
v0.14 #44
Conversation
@@ -1,6 +1,8 @@ | |||
Revision history for Data-Validate-Sanctions | |||
|
|||
{{$NEXT}} | |||
|
|||
0.14 2022-08-05 03:02:40+00:00 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing release notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it was made by dzil automatically when it was released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean you need to add release notes (explain the changes between 0.13 and 0.14)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected the comment :D
@@ -303,8 +303,8 @@ sub _load_data { | |||
foreach my $sanctioned_name (keys $self->{_index}->%*) { | |||
my @tokens = _clean_names($sanctioned_name); | |||
$self->{_sanctioned_name_tokens}->{$sanctioned_name} = \@tokens; | |||
foreach my $token (@tokens){ | |||
$self->{_token_sanctioned_names}->{$token}->{$sanctioned_name}=1; | |||
foreach my $token (@tokens) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the change except formatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing, just formatting, it was made by dzil automatically when it was released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the change is just formatting, why was it released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shantanu-deriv I think you are misunderstanding . Dzil will do perltidy and pump up version number when we run dzil release
. we should commit & merge this change after releasing the package to cpan.org
but yes you are right, @evgeniy-deriv should update changes
file before he release to cpan.org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed, but now package is released on cpan.org.
Anyway this PR needs to be merged explaining that changes between 0.13 and 0.14 and so far I see only formatting changes between it
Co-authored-by: Shantanu Patil <[email protected]>
No description provided.