DTRA-2157 / Kate / Input component fix #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
wojciech-deriv,
prince-deriv and
balakrishna-deriv
as code owners
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
Deploying quill-ui with
|
| Latest commit: |
8f5dece
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0bcfe3da.quill-ui.pages.dev |
| Branch Preview URL: | https://kate-dtra-2157-input-roundin.quill-ui.pages.dev |
prince-deriv
approved these changes
Oct 28, 2024
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the way how the value is truncate in input. Previously toFixed was used and the problem that it round the value: for 2 decimals ---> 5.67 ---> user type '8' ---> 5.678 ---> 5.678.toFixed(2) --> 5.68.
New behaviour: the cut off will not round the value: for 2 decimals ---> 5.67 ---> user type '8' ---> 5.678 ---> toFixedWithoutRounding(5.678, 2) --> 5.67.
Video explanation of the bug:
Incorrect.decimal.value.in.barrier.mp4