-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suisin/fix: make InputPhoneNumber not following any format in default #494
Merged
prince-deriv
merged 5 commits into
deriv-com:master
from
suisin-deriv:suisin/remove_format_for_input_phone_no
Nov 8, 2024
Merged
Suisin/fix: make InputPhoneNumber not following any format in default #494
prince-deriv
merged 5 commits into
deriv-com:master
from
suisin-deriv:suisin/remove_format_for_input_phone_no
Nov 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisin-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
wojciech-deriv,
prince-deriv and
balakrishna-deriv
as code owners
November 7, 2024 10:28
amina-deriv
reviewed
Nov 7, 2024
...components/Input/input-phone-number/__tests__/__snapshots__/input-phone-number.test.tsx.snap
Show resolved
Hide resolved
jia-deriv
reviewed
Nov 7, 2024
jia-deriv
approved these changes
Nov 8, 2024
thisyahlen-deriv
approved these changes
Nov 8, 2024
amina-deriv
approved these changes
Nov 8, 2024
kate-deriv
approved these changes
Nov 8, 2024
henry-deriv
approved these changes
Nov 8, 2024
@suisin-deriv can you update storybook description |
henry-deriv
approved these changes
Nov 8, 2024
prince-deriv
approved these changes
Nov 8, 2024
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the limitation of numbers for InputPhoneNumber field