henry/dtra-676/fix: remove unused files #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-deriv
reviewed
Jan 5, 2024
| @@ -18,4 +18,4 @@ module.exports = { | |||
| setURL, | |||
| getApiToken: () => 'hhh9bfrbq0G3dRf', | |||
| api : new LiveApi({ websocket, appId: 1 }), | |||
| }; | |||
| }; | |||
There was a problem hiding this comment.
The mysterious story of the gap that appeared
There was a problem hiding this comment.
ah yeah i first had it deleted and had to readd it back because it was needed lol. i'll remove the space
balakrishna-deriv
previously approved these changes
Jan 8, 2024
kate-deriv
approved these changes
Jan 8, 2024
| @@ -1,5 +1,4 @@ | |||
| import React from 'react'; | |||
| // import Footer from './footer.jsx'; | |||
| import Head from './head.jsx'; | |||
| import Header from './header.jsx'; | |||
| // import MobileMenu from './mobile_menu.jsx'; | |||
There was a problem hiding this comment.
Maybe all this commented code also can be deleted? Lines 4, 74, 79
| // current_landing_company_shortcode, | ||
| // MetaTrader.isEligible(), | ||
| // // We then pass the list of found mt5fin company shortcodes as an array | ||
| // arr_mt5fin_shortcodes |
There was a problem hiding this comment.
Maybe it can also be deleted?
|
Preview Link: https://pr-592.smarttrader-preview.pages.dev
|
balakrishna-deriv
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change