Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix type error for Python 3.8 #754

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: Fix type error for Python 3.8 #754

merged 1 commit into from
Aug 13, 2024

Conversation

last-partizan
Copy link
Collaborator

No description provided.

@last-partizan last-partizan merged commit 5cc37c2 into master Aug 13, 2024
22 checks passed
@last-partizan last-partizan deleted the fix-type-error branch August 13, 2024 08:08
@mschoettle
Copy link
Contributor

This brings back the issue that was fixed with #744. It seems that this was fixed for Python 3.8 which is not supported for this package anymore. Can we please revert this?

@last-partizan
Copy link
Collaborator Author

Sure, created a PR reverting it.

After i merge it, please create separate PR adding a test for get_type_hits, so we accidentally do not break it again.

last-partizan added a commit that referenced this pull request Sep 4, 2024
@mschoettle
Copy link
Contributor

Thanks! I'll add a test in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants