-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encode/decode_negative_targetid from ra,dec #724
Conversation
A few thoughts. None of which are compulsory to consider or implement:
|
thanks for the comments @geordie666 . Updates:
Although in principle I agree with your yaml file parameters, in practice I've run out of steam tonight and I'm not sure it really matters here. The number of bits are hardcoded in two functions, and if those ever get out of sync the unit tests will catch that (which I also confirmed). Summary:
|
Thanks @sbailey. These changes all look good to me. |
This PR provides prototype code for generating a negative TARGETID based upon (ra,dec), unique to within ~1.2 milliarcsec. These are negative to distinguish them from the positive TARGETIDs generated from
encode_targetid(objid, brickid, release, ...)
from imaging surveys objects.This PR is motivated by desihub/fiberassign#335 for creating multiple sky targets on-the-fly. Currently when fiberassign creates a sky TARGETID it is based upon TILEID and positioner LOCATION, but this isn't unique if we start creating multiple sky targets per positioner, some of which will overlap other positioners. This PR provides a standardized way of generating these TARGETIDs in desitarget, which I think should "own" the concept of TARGETID rather than putting this code into fiberassign. It may also be useful for other future cases with new programs.
Discuss:
@geordie666 @dstndstn @tskisner
Note: once we converge on what we want, I'd also add some unit tests.