Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .readthedocs.yml and update documentation configuration #459

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

weaverba137
Copy link
Member

This PR closes #456.

Besides the new .readthedocs.yml file, installation of desiutil is moved from the setup.py file to the doc/rtd_requirements.txt file.

@weaverba137 weaverba137 self-assigned this Aug 7, 2023
@weaverba137
Copy link
Member Author

PS, I have also verified that this branch builds successfully on ReadTheDocs, in addition to the GitHub Actions test.

Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I will trust your testing. Merge when ready.

@weaverba137
Copy link
Member Author

Thanx, I just updated the change log and will merge after the tests complete.

@araichoor
Copy link
Contributor

I surely trust your work here; in case I can be useful with running some checks, please let me know.
otherwise, of course, you can merge at your will.
thanks!

@weaverba137 weaverba137 merged commit 2c8bf04 into main Aug 7, 2023
14 checks passed
@weaverba137 weaverba137 deleted the rtd-conf-file branch August 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .readthedocs.yml
3 participants