Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update max value #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eaglebk
Copy link

@eaglebk eaglebk commented Sep 29, 2023

Description:
This PR updates the getMaxValue function to improve code readability and efficiency. The current implementation uses reduce to find the maximum value in the dataset, making the code more concise and eliminating the need for an explicit loop. Additionally, it provides a default value of 0 for cases when the dataset is empty or null

Changes Made:
Refactored the getMaxValue function to use the reduce method.
Added a default value of 0 to handle empty or null datasets.
Removed the explicit loop for finding the maximum value.

Testing:
The updated function has been tested with various datasets, including empty and null datasets, to ensure that it correctly returns the maximum value or the default value 0 when appropriate.

Please review and merge this Pull Request if the changes align with the project's goals. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant