adds ability to filter out users [issue #3] #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gs.yml file. introduces DisqualifiedUser model/collection. Tweets collection gets 'disqualify' function which TweetsView.pickRandom calls before picking winner.
|
Thanks Robert! Looks good to me. @jamescarr want to merge this one since you opened the issue? |
|
I checked it out and it just needs a couple fixes. It looks like the previous winners get removed as a side effect when picking the next winner. Not a big deal, but I kind of like keeping the previous winners highlighted since they don't get selected anyway. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a filter based on a local yaml file containing usernames to exclude from the raffle selection. We could potentially modify to load this list dynamically from some other service and include previous winners (issue #4).