Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ability to filter out users [issue #3] #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rboyd
Copy link

@rboyd rboyd commented Sep 3, 2011

This commit implements a filter based on a local yaml file containing usernames to exclude from the raffle selection. We could potentially modify to load this list dynamically from some other service and include previous winners (issue #4).

…gs.yml file. introduces DisqualifiedUser model/collection. Tweets collection gets 'disqualify' function which TweetsView.pickRandom calls before picking winner.
@bgrins
Copy link
Contributor

bgrins commented Sep 6, 2011

Thanks Robert! Looks good to me. @jamescarr want to merge this one since you opened the issue?

@james-carr
Copy link

I checked it out and it just needs a couple fixes. It looks like the previous winners get removed as a side effect when picking the next winner. Not a big deal, but I kind of like keeping the previous winners highlighted since they don't get selected anyway. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants