-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use xarray.open_zarr and make aiohttp and s3fs optional #1016
Merged
vincentsarago
merged 6 commits into
feature/add-xarray-package
from
path/use-open-zarr-and-optional-dependencies
Nov 4, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3fefc67
use xarray.open_zarr and make aiohttp and s3fs optional
vincentsarago 943f5eb
add support for references
vincentsarago 3d40b99
tests prefixed protocol
vincentsarago 8dffefc
use tmp_dir for reference
vincentsarago ea4709c
add parquet support
vincentsarago b9b7f30
remove kerchunk support
vincentsarago File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -30,19 +30,25 @@ classifiers = [ | |||||||||||||||||||||||||||||||||
dynamic = ["version"] | ||||||||||||||||||||||||||||||||||
dependencies = [ | ||||||||||||||||||||||||||||||||||
"titiler.core==0.19.0.dev", | ||||||||||||||||||||||||||||||||||
"cftime", | ||||||||||||||||||||||||||||||||||
"h5netcdf", | ||||||||||||||||||||||||||||||||||
"xarray", | ||||||||||||||||||||||||||||||||||
"rioxarray", | ||||||||||||||||||||||||||||||||||
"zarr", | ||||||||||||||||||||||||||||||||||
"fsspec", | ||||||||||||||||||||||||||||||||||
"s3fs", | ||||||||||||||||||||||||||||||||||
"aiohttp", | ||||||||||||||||||||||||||||||||||
"pandas", | ||||||||||||||||||||||||||||||||||
"httpx", | ||||||||||||||||||||||||||||||||||
"zarr", | ||||||||||||||||||||||||||||||||||
"h5netcdf", | ||||||||||||||||||||||||||||||||||
"cftime", | ||||||||||||||||||||||||||||||||||
] | ||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||
[project.optional-dependencies] | ||||||||||||||||||||||||||||||||||
s3 = [ | ||||||||||||||||||||||||||||||||||
"s3fs", | ||||||||||||||||||||||||||||||||||
] | ||||||||||||||||||||||||||||||||||
http = [ | ||||||||||||||||||||||||||||||||||
"aiohttp", | ||||||||||||||||||||||||||||||||||
] | ||||||||||||||||||||||||||||||||||
all = [ | ||||||||||||||||||||||||||||||||||
"s3fs", | ||||||||||||||||||||||||||||||||||
"aiohttp", | ||||||||||||||||||||||||||||||||||
] | ||||||||||||||||||||||||||||||||||
Comment on lines
+48
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Suggestion to align with above comment about optional dependencies There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @maxrjones I'll take care of this either in the main PR or in another one later |
||||||||||||||||||||||||||||||||||
test = [ | ||||||||||||||||||||||||||||||||||
"pytest", | ||||||||||||||||||||||||||||||||||
"pytest-cov", | ||||||||||||||||||||||||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO Zarr and h5netcdf should be optional dependencies so people could deploy titiler-xarray with only one option to keep image size down. This may also make it easier to support other HDF5 readers that work better for remote files in the future (e.g., https://github.com/gauteh/hidefix).