Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added dotnet80 stack #130

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

msivasubramaniaan
Copy link

What does this PR do / why we need it

Added dotnet80 stack

Which issue(s) does this PR fix

devfile/api#1540

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

How to test changes / Special notes to the reviewer

Signed-off-by: msivasubramaniaan <[email protected]>
@openshift-ci openshift-ci bot requested review from elsony and Jdubrick July 23, 2024 08:24
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

devfile/registry#452 needs to be merged first

/hold

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm after all checks are passing

Copy link

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msivasubramaniaan, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should be rebased before we can merge if still relevant @msivasubramaniaan

cc @thepetk

@openshift-ci openshift-ci bot removed the lgtm label Sep 10, 2024
Copy link

openshift-ci bot commented Sep 10, 2024

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants