Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Reset by time #171

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Feature: Reset by time #171

merged 3 commits into from
Nov 10, 2023

Conversation

nanic
Copy link
Contributor

@nanic nanic commented Oct 19, 2023 •
edited
Loading

Description

Adds support for reset command to reset offset to offset from a passed in datetime/timestamp(epoch)

Fixes #169 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • the change is mentioned in the ## [Unreleased] section of CHANGELOG.md
  • the configuration yaml was changed and the example config in README.md was updated
  • a usage example was added to README.md
  • tests for the changes have been implemented (see: Testing your changes)

@ayushghosh
Copy link

ayushghosh commented Oct 30, 2023 •
edited
Loading

Can we expedite review/merge this PR ?

@d-rk d-rk merged commit 321a6eb into deviceinsight:main Nov 10, 2023
6 checks passed
@d-rk
Copy link
Collaborator

d-rk commented Nov 10, 2023

@nanic thank you for the PR and sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-rk d-rk d-rk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow reset of Kafka lag by time
3 participants
@nanic @ayushghosh @d-rk