Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod override fields affinity and tolerations #203

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

PasinduDissMrYum
Copy link
Contributor

@PasinduDissMrYum PasinduDissMrYum commented Jul 29, 2024

Description

Please include a summary of the change and which issue is fixed.
List any dependencies that are required for this change.

Fixes # (issue)
This PR adds the pod overrides affinity and tolerations, unfortunately nodeSelector field is not enough for all use cases.
The changes in this PR include:

  • Addition of affinity field for spec type pod overrides
  • Additions of tolerations field for spec type pod overrides

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Documentation

  • the change is mentioned in the ## [Unreleased] section of CHANGELOG.md
  • the configuration yaml was changed and the example config in README.adoc was updated
  • a usage example was added to README.adoc
  • tests for the changes have been implemented (see: Testing your changes)

@PasinduDissMrYum
Copy link
Contributor Author

Hey @d-rk could I please get an approval to run the workflow 🙏

@d-rk
Copy link
Collaborator

d-rk commented Aug 13, 2024

@PasinduDissMrYum sorry for the delay. I'm quite busy before my vacation here. I cannot promise you that I am able to review you PR before my vacation. So please be patient, it is on my list.
Regarding your PR workflow run: you have to rebase your branch on the latest main branch, otherwise ITs won't work at all.

@d-rk
Copy link
Collaborator

d-rk commented Aug 14, 2024

@PasinduDissMrYum thank you for the PR, I made some adjustments and the code is now ready to merge.

@d-rk d-rk merged commit 2fb456e into deviceinsight:main Aug 14, 2024
6 checks passed
@PasinduDissMrYum
Copy link
Contributor Author

Thank you @d-rk!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants