Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect number of bytes returned by value decoders #226

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

soundmonster
Copy link

@soundmonster soundmonster commented Dec 19, 2024

Description

Respect the number of bytes generated by value decoders for hex and Base64.

Fixes issue #227: producing from a file with Base64-encoded values that start with zeros results in empty values in the produced messages. Payloads that start with "AA.." are common for e.g. Avro.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • the change is mentioned in the ## [Unreleased] section of CHANGELOG.md
  • the configuration yaml was changed and the example config in README.adoc was updated
  • a usage example was added to README.adoc
  • tests for the changes have been implemented (see: Testing your changes)

@soundmonster soundmonster marked this pull request as ready for review December 19, 2024 15:31
@soundmonster
Copy link
Author

Sorry for the failed build, I forgot to add the JSON file fixture. I've fixed it now and tested on my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant