-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore failed descriptor reads on Windows #362
Conversation
This brings the Windows implementation in line with Linux Fixes #361
I tossed a release commit into the branch on the off chance you'd be willing to get this released today, but would be happy to drop/edit that commit if you're not ready to release yet. |
I've just added another commit in the middle of the branch that adds better low-level handling of the characteristics. After testing my first fix, I found that it was still failing on some devices because |
Discovery of a peripheral's services should not error out merely because one of the characteristics encountered an "AccessDenied" or similar error
Release commit has been amended with today's date. |
Ok, I gotta say, submitting the CHANGELOG update and updating it's date in the PR daily is a surprisingly good way to make sure I don't forget about this PR. :P |
Is the release to crates.io automatic? Just wondering when I should I update my project that is using |
Nevermind - I see this was merged into |
Nope, releases are done by hand still, but it's published now. |
Thanks! Already have my PR up to use the new version and it's one of the last things for getting the app deployed to prod, so thank you! |
This brings the Windows implementation in line with Linux
Fixes #361