-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote Workers and Worker-Supervisor #140
Open
matyasmarkovics
wants to merge
13
commits into
devinus:master
Choose a base branch
from
matyasmarkovics:mm-remote-workers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remote Workers and Worker-Supervisor #140
matyasmarkovics
wants to merge
13
commits into
devinus:master
from
matyasmarkovics:mm-remote-workers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervisor as poolboy_sup
* Factor out supervisor and worker creation from init/3, so that state record can be initialized without the default:undefined
…proc if Pid is not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote Workers
I needed to create a pool of processes similar to the
rpc
module implementation in Erlang/OTP. -rpc
(orrex
) is a single process, I needed a pool of them. - This led me to extend poolboy, so that (local) workers could be started by a supervisor on a remote node.For this to work these are the necessary steps:
Pid
of the Worker-Supervisor, even if remote, seefind_pid/1
new_worker/2
stop
if they goDOWN
node
if Worker-Supervisor is remote andstop
onnodedown
gen_server:stop/1
, so that it works remotely too. See:stop_supervisor/2