-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: Propagate metadata down to _arg_defaults #2459
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2459 +/- ##
==========================================
- Coverage 87.01% 87.01% -0.01%
==========================================
Files 239 239
Lines 45023 45028 +5
Branches 8404 8406 +2
==========================================
+ Hits 39176 39180 +4
- Misses 5114 5115 +1
Partials 733 733 ☔ View full report in Codecov by Sentry. |
name = self.sregistry.make_name(prefix='init') | ||
efunc = make_callable(name, init) | ||
init = Call(name, efunc.parameters) | ||
efuncs, init = make_zero_init(obj, self.rcompile, self.sregistry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get read of gpu-create
and just do if is_transient
and have the zero init in the core no matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed offline, we would break user code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wouldn't we just need is_gou_create
to return true
for any is_tansient
for now so that any transient function is directly allocated in gen code and add a deprecation warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the users who have been using gpu-create don't start creating is_transient
Functions, how can it possibly work?
I agree though that gpu-create should get deprecated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well yes why I said as a first step is_gpu_create
should behave as now, but returns true
as well for is_transient
Function and throw a warning to tell people "stop using gpu-create and set your function with is_transient"
102971a
to
22e5e96
Compare
22e5e96
to
3964023
Compare
This is necessary for optimization purposes in PRO