Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: Propagate metadata down to _arg_defaults #2459

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

FabioLuporini
Copy link
Contributor

This is necessary for optimization purposes in PRO

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes missing coverage. Please review.

Project coverage is 87.01%. Comparing base (2ae6822) to head (3964023).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
devito/passes/iet/definitions.py 35.71% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2459      +/-   ##
==========================================
- Coverage   87.01%   87.01%   -0.01%     
==========================================
  Files         239      239              
  Lines       45023    45028       +5     
  Branches     8404     8406       +2     
==========================================
+ Hits        39176    39180       +4     
- Misses       5114     5115       +1     
  Partials      733      733              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

name = self.sregistry.make_name(prefix='init')
efunc = make_callable(name, init)
init = Call(name, efunc.parameters)
efuncs, init = make_zero_init(obj, self.rcompile, self.sregistry)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get read of gpu-create and just do if is_transient and have the zero init in the core no matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline, we would break user code

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't we just need is_gou_create to return true for any is_tansient for now so that any transient function is directly allocated in gen code and add a deprecation warning

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the users who have been using gpu-create don't start creating is_transient Functions, how can it possibly work?

I agree though that gpu-create should get deprecated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well yes why I said as a first step is_gpu_create should behave as now, but returns true as well for is_transient Function and throw a warning to tell people "stop using gpu-create and set your function with is_transient"

@FabioLuporini FabioLuporini merged commit 28e5ef2 into master Oct 3, 2024
31 checks passed
@FabioLuporini FabioLuporini deleted the fix-gpu-create branch October 3, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants