-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add Flake8 linting to notebooks #2484
base: master
Are you sure you want to change the base?
Conversation
I personally wouldn't. Flake8 is really not adapted to notebooks, where readable and potentially longer lines are preferred. |
We could always set a custom rule to ignore "line too long" |
Looking at it, there are only about 5 "Line too long" warnings in the whole output, and most are only 5 or so characters over. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2484 +/- ##
==========================================
- Coverage 87.26% 87.26% -0.01%
==========================================
Files 238 238
Lines 45278 45271 -7
Branches 4022 4022
==========================================
- Hits 39512 39505 -7
Misses 5085 5085
Partials 681 681 ☔ View full report in Codecov by Sentry. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diff is way too big for just a few line change. Also those depa should be in requirements-testing.txt not hardcoded in the yaml
Yeah, I messed up adding the changes in one of the notebooks somehow. Will fix in due course |
I was just going off how the Flake8 workflow already works, can change this |
@ggorman pointed out that you can now Flake8 lint Jupyter Notebooks. We should probably do this.