Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: fix equation pickling #2490

Merged
merged 1 commit into from
Nov 18, 2024
Merged

api: fix equation pickling #2490

merged 1 commit into from
Nov 18, 2024
+20 −2

Conversation

mloubout
Copy link
Contributor

No description provided.

@mloubout mloubout added bug-py API api (symbolics, types, ...) labels Nov 18, 2024
FabioLuporini
FabioLuporini approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@FabioLuporini FabioLuporini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncontroversial

EdCaunt
EdCaunt approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. Approved

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.29%. Comparing base (279f074) to head (3bbbe79).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2490   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files         238      238           
  Lines       45366    45378   +12     
  Branches     4029     4029           
=======================================
+ Hits        39602    39614   +12     
  Misses       5083     5083           
  Partials      681      681

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@mloubout mloubout merged commit bedb1a9 into master Nov 18, 2024
31 checks passed
@mloubout mloubout deleted the pickel-eq branch November 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdCaunt EdCaunt EdCaunt approved these changes

@FabioLuporini FabioLuporini FabioLuporini approved these changes

Assignees
No one assigned
Labels
API api (symbolics, types, ...) bug-py
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mloubout @FabioLuporini @EdCaunt