DEVC-882 fixed issues related to the services #2
Conversation
|
Nair seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
There was a problem hiding this comment.
@sujith-mn thanks for your PR and trying to bring this further.
However, I think we should first get in touch and align on a strategy how to solve it properly.
| <!-- Required for secrutiy REST service --> | ||
| <dependency> | ||
| <groupId>org.springframework.security</groupId> | ||
| <artifactId>spring-security-web</artifactId> |
There was a problem hiding this comment.
In general we have conventions and best practices in devonfw that should be strictly followed. Indentation is 2 spaces for any file format.
Please use devonfw IDE and proper formatting.
As you can see in the diffs here on github for your changes in core/pom.xml it is not possible to see what really has been changed (this is called "diff wars"). Please try to align your formatting to avoid this.
Also have a look here:
https://github.com/devonfw/devon4j/blob/develop/documentation/coding-conventions.asciidoc
There was a problem hiding this comment.
formatted the pom.xml and committed again
There was a problem hiding this comment.
Replaced the pom files with latest devon (3.2.1) pom files to support new java version (No JAXB on java 11).
| @GET | ||
| @Path("/employee/{id}/") | ||
| public EmployeeEto getEmployee(@PathParam("id") CompositeEmployeeKey id); | ||
| @GET | ||
| @Path("/employee/{employeeId}/company/{companyId}") | ||
| public EmployeeEto getEmployee(@PathParam("employeeId") String employeeId, @PathParam("companyId") String companyId); |
There was a problem hiding this comment.
It seems you have been facing some technical issues - maybe with JSON mapping or bean-mapping.
These can all be solved properly and easily. See e.g.:
https://github.com/devonfw/devon4j/blob/develop/documentation/guide-json.asciidoc#custom-mapping
If you have issues get it touch. We can even do a skype or teams call to get it resolved.
However, the impact should not change the design and expose the technical problems by chaning the entire API and give up our REST conventions. The idea for the composite keys is IMHO to provide a solution with minimal impact on design, CobiGen templates, etc. Therefore this approach is not leading to the right direction.
There was a problem hiding this comment.
reverted the changes, put the composite id back to accept the composite id.
…tely for search not required to be part of the other fields
|
Hi @hohwille, @sujith-mn could we close this? |
Fixed the below issues: