#3: implement component rules C3 + C4 - violations #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Business architecture definition of dependencies test.
Components service layers should not depend on each other.
NOT READY!
…llen/archunit into add-component-rules
Added a more concise error message.
Deleted C2 rule since it is obsolete. It will be covered by devonfw-sample#21. Refactoring by automatic code-formatting of devonfw-ide.
Minor refactoring. Changed ArchCondition to final. Renamed boolean dependencyAllowed to isAllowedDependency.
…entTask.java Uncommented the dependency towards task.dataaccess layer from componentb.service. It is useful to note the violation but the error message resolved by our layer test might be unexpected when checking for component tests.
Add component rules C5-C7
HOTFIX general component use. Co-Authored-By: NicolasVanBellen <[email protected]>
@NicolasVanBellen Adjusted component rules C3-C7 to use the newly introduced PackageStructure type. Co-Authored-By: NicolasVanBellen <[email protected]>
Updated PackageStructure.java: - Added a projects architecture DEFAULT_COMPONENT field. - Added a isComponentGeneral() getter. Updated ComponentRuleTest.java: - Reimplemented C3 and C6 using a custom ArchCondition + PackageStructure - Resolved all review annotation of @hohwille Co-Authored-By: NicolasVanBellen <[email protected]>
Reworked component rules according to recent review. - added DescribedPredicates - added composeViolationMessage method - added test for general component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3
DO NOT MERGE.
This fork branch contains classes demonstrating archunit component rules violations:
Namely C3 and C4 violations.