Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement third party E2, E5, E6 violations #32

Draft
wants to merge 6 commits into
base: violations/thirdparty
Choose a base branch
from

Conversation

dendmicap
Copy link
Contributor

@dendmicap dendmicap commented Mar 8, 2023

#5
#8
#31

DO NOT MERGE

@hohwille hohwille marked this pull request as draft March 14, 2023 09:10
@dendmicap dendmicap marked this pull request as ready for review March 22, 2023 11:12
@hohwille hohwille marked this pull request as draft March 23, 2023 16:24
Copy link
Contributor

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dendmicap thanks for your PR. Looks good to demonstrate the rule violations. 👍

@hohwille
Copy link
Contributor

hohwille commented Mar 23, 2023

IMHO the way ArchUnit and the rules report the violations looks perfectly clear to me.
The only slight nice to have improvement would be the ... because Use the ... part that does not make sense from Engish grammar point of view. Could be addressed with #19

Error:  Failures: 
Error:    Architecture Violation [Priority: MEDIUM] - Rule 'no classes should depend on classes that have fully qualified name 'javax.persistence.Convert', because Use the javax.persistence.Converter annotation on a custom converter which implements the javax.persistence.AttributeConverter instead of the 'javax.persistance.Convert' annotation' was violated (1 times):
Class <com.devonfw.sample.archunit.general.dataaccess.violations.ThirdPartyDataMappingPersistanceNotOk> is annotated with <javax.persistence.Convert> in (ThirdPartyDataMappingPersistanceNotOk.java:0)
Error:    Architecture Violation [Priority: MEDIUM] - Rule 'no classes should depend on classes that reside in a package 'com.mysema.query..', because Use official QueryDSL (com.querydsl.* e.g. from com.querydsl:querydsl-jpa).' was violated (1 times):
Field <com.devonfw.sample.archunit.general.dataaccess.violations.ThirdPartyMysemaNotOk.jpaQuery> has type <com.mysema.query.jpa.impl.JPAQuery> in (ThirdPartyMysemaNotOk.java:0)
Error:    Architecture Violation [Priority: MEDIUM] - Rule 'no classes should depend on classes that have fully qualified name 'com.google.common.base.Objects', because Use Java standards instead (java.util.Objects).' was violated (1 times):
Constructor <com.devonfw.sample.archunit.general.dataaccess.violations.ThirdPartyObjectNotOk.<init>()> calls method <com.google.common.base.Objects.equal(java.lang.Object, java.lang.Object)> in (ThirdPartyObjectNotOk.java:7)

@hohwille hohwille changed the base branch from master to violations/thirdparty April 25, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants