Feature/undo failure repo #152
Conversation
|
Mkassi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| cd .. | ||
|
|
||
| az repos delete --id "$repo_id" --org "$organization" -p "$project" --yes | ||
| if [ "$?" == 0 ] |
There was a problem hiding this comment.
SC2181: Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
There was a problem hiding this comment.
I’m LiftBot and I automatically analyze new code in code review, and comment when I find potential bugs. I also accept comments as commands. Just @sonatype-lift followed by the command: ignore to mark as false positive, unignore to undo, ignoreall to ignore all issues in this PR, exclude <file|path|tool|issue> to discover config file snippets, and help to see this message. Click here to add LiftBot to another repo.
Closes #97
First, errors in the "Create" case were taken into account, this is the first draft, the script still needs to be adjusted in the "Importing" case