Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scancode file adapter #193

Merged
merged 16 commits into from
Aug 17, 2023

Conversation

ohecker
Copy link
Member

@ohecker ohecker commented Aug 13, 2023

This closes #191 and #192.

See Javadoc of com.devonfw.tools.solicitor.componentinfo (and subpackages) and
the class diagram contained in the javadoc

Copy link
Collaborator

@chrimih chrimih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished

@ohecker
Copy link
Member Author

ohecker commented Aug 17, 2023

I also renamed getNoticeFilePath() (of ComponentInfo) to getNoticeFileUrl() and getLicenseFilePath() (of LicenseInfo) to getLicenseUrl(). This reflects that these are URLs now. (I was thinking whether it should be getLicenseFileUrl() or getLicenseUrl() but decided to take getLicenseUrl() because it might refer to some web URL.)

@ohecker ohecker requested a review from chrimih August 17, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScancodeFileAdapter needs refactoring
2 participants