Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FI-846) Fix dependency structure #135

Merged
merged 5 commits into from
Jul 26, 2023
Merged

feat(FI-846) Fix dependency structure #135

merged 5 commits into from
Jul 26, 2023

Conversation

NikolasHai
Copy link
Contributor

This MR introduces the following changes:

  1. Split implementations of LedgerEnv in icrc1-test-env into icrc1-test-env-replica and icrc1-test-env-state-machine
  2. icrc1-test-env only depends on anyhow, candid, serde, and async-trait

roman-kashitsyn
roman-kashitsyn reviewed Jul 25, 2023
View reviewed changes
test/env/state-machine/Cargo.toml Outdated Show resolved Hide resolved
test/env/state-machine/lib.rs Outdated Show resolved Hide resolved
test/env/state-machine/lib.rs Outdated Show resolved Hide resolved
test/env/state-machine/lib.rs Outdated Show resolved Hide resolved
@roman-kashitsyn roman-kashitsyn merged commit bc94ae2 into main Jul 26, 2023
1 check failed
@roman-kashitsyn roman-kashitsyn deleted the FI-846-fix-dependency-structure branch July 26, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-kashitsyn roman-kashitsyn roman-kashitsyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolasHai @roman-kashitsyn