Update TextualEncoding.md #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Roman Kashitsyn <[email protected]>
standards/ICRC-1/TextualEncoding.md
Outdated
|
|
||
| * [`ic-js`](https://github.com/dfinity/ic-js/tree/main/packages/ledger-icrc#gear-encodeicrcaccount) (JavaScript). | ||
| * [`icrc-ledger-types`](https://docs.rs/icrc-ledger-types/0.1.2/icrc_ledger_types/icrc1/account/struct.Account.html) version `0.1.2` and higher (Rust). | ||
| * [`icrc1`](https://github.com/NatLabs/icrc1) (Motoko) |
There was a problem hiding this comment.
The NatLabs/icrc1 respository implements an obsolete textual representation that the working group rejected. The reference Motoko implementation is in this repository: https://github.com/dfinity/ICRC-1/blob/main/ref/Account.mo
There was a problem hiding this comment.
thanks for flagging
There was a problem hiding this comment.
can we publish this as a mops.one library? @roman-kashitsyn
There was a problem hiding this comment.
I think we've already had this conversation: #98 (comment)
There was a problem hiding this comment.
good memory :D
|
@MarioDfinity can we merge this? |
MarioDfinity
approved these changes
Dec 12, 2023
|
@letmejustputthishere feel free to merge when CI is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MarioDfinity i think it would be helpful to point interested parties to an implementation