New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recover subtype error from custom deserializer #456

Merged

chenyan-dfinity merged 1 commit into master from fix-opt

Jul 25, 2023

Contributor

chenyan-dfinity commented Jul 25, 2023

No description provided.


          recover subtype error from custom deserializer

575e7e4

github-actions bot commented Jul 25, 2023

Benchmark for `1d81ba0`

Click to view benchmark

Test	Base	PR	%
Blob/&str	260.2±136.69µs	226.0±108.94µs	-13.14%
Blob/ByteBuf	150.8±47.02µs	149.7±45.85µs	-0.73%
Blob/Bytes	106.7±43.15µs	107.2±41.90µs	+0.47%
Blob/String	300.1±146.83µs	262.8±122.78µs	-12.43%
Collections/vec (text, nat)	68.4±1.09ms	69.4±1.30ms	+1.46%
Collections/vec int	32.4±0.10ms	32.4±0.10ms	0.00%
Collections/vec int64	17.6±0.23ms	18.8±0.33ms	+6.82%
Collections/vec nat8	13.7±0.02ms	13.7±0.02ms	0.00%
option list/1024	1368.2±6.13µs	1382.0±11.40µs	+1.01%
profiles/1024	2.6±0.01ms	2.6±0.00ms	0.00%
variant list/1024	1118.5±1.27µs	1127.8±2.08µs	+0.83%

rvanasa approved these changes

View reviewed changes

chenyan-dfinity merged commit 457b5be into master

3 checks passed

chenyan-dfinity deleted the fix-opt branch

July 25, 2023 19:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet