Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc #466

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Misc #466

merged 3 commits into from
Sep 13, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Sep 9, 2023

  • Add merge_init_args to handle candid:args metadata in candid::utils and Candid UI.
  • record/variant macro

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Benchmark for c7bba25

Click to view benchmark
Test Base PR %
Blob/&str 308.4±155.07µs 274.6±90.46µs -10.96%
Blob/ByteBuf 195.1±64.20µs 180.6±54.01µs -7.43%
Blob/Bytes 127.9±50.95µs 130.9±51.38µs +2.35%
Blob/String 355.9±173.86µs 356.3±172.82µs +0.11%
Collections/vec (text, nat) 83.1±0.84ms 82.9±1.30ms -0.24%
Collections/vec int 39.1±0.18ms 39.2±0.16ms +0.26%
Collections/vec int64 22.4±0.23ms 22.7±0.28ms +1.34%
Collections/vec nat8 16.6±0.03ms 17.2±0.10ms +3.61%
option list/1024 1618.8±3.57µs 1631.7±6.36µs +0.80%
profiles/1024 3.2±0.00ms 3.2±0.01ms 0.00%
variant list/1024 1290.4±3.46µs 1292.9±3.27µs +0.19%

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Benchmark for 6e8e92c

Click to view benchmark
Test Base PR %
Blob/&str 195.4±66.77µs 193.7±70.65µs -0.87%
Blob/ByteBuf 138.7±50.80µs 140.6±50.31µs +1.37%
Blob/Bytes 99.6±33.99µs 100.1±35.08µs +0.50%
Blob/String 211.0±75.20µs 206.0±73.09µs -2.37%
Collections/vec (text, nat) 67.5±0.81ms 63.8±0.58ms -5.48%
Collections/vec int 31.1±0.14ms 29.8±0.07ms -4.18%
Collections/vec int64 17.3±0.17ms 17.5±0.17ms +1.16%
Collections/vec nat8 13.2±0.07ms 13.2±0.06ms 0.00%
option list/1024 1405.6±2.59µs 1356.2±1.68µs -3.51%
profiles/1024 2.6±0.00ms 2.6±0.00ms 0.00%
variant list/1024 1133.7±4.92µs 1128.0±1.39µs -0.50%

@chenyan-dfinity chenyan-dfinity merged commit a1eb218 into master Sep 13, 2023
3 checks passed
@chenyan-dfinity chenyan-dfinity deleted the merge-init-arg branch September 13, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants