Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate check for IDE #484

Merged
merged 2 commits into from
Oct 23, 2023
Merged

remove duplicate check for IDE #484

merged 2 commits into from
Oct 23, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

No description provided.

@github-actions
Copy link

Benchmark for e3e6709

Click to view benchmark
Test Base PR %
Blob/&str 282.2±84.41µs 270.1±83.38µs -4.29%
Blob/ByteBuf 194.1±68.02µs 203.2±68.91µs +4.69%
Blob/Bytes 126.9±51.53µs 138.1±53.46µs +8.83%
Blob/String 365.6±180.54µs 373.6±196.47µs +2.19%
Collections/vec (text, nat) 83.9±1.24ms 82.6±1.33ms -1.55%
Collections/vec int 40.0±0.13ms 38.9±0.13ms -2.75%
Collections/vec int64 22.0±0.36ms 21.8±0.36ms -0.91%
Collections/vec nat8 17.2±0.06ms 17.3±0.04ms +0.58%
option list/1024 1617.2±4.24µs 1612.6±6.84µs -0.28%
profiles/1024 3.2±0.00ms 3.2±0.00ms 0.00%
variant list/1024 1282.0±3.11µs 1292.4±1.96µs +0.81%

@chenyan-dfinity chenyan-dfinity merged commit 2308128 into master Oct 23, 2023
4 checks passed
@chenyan-dfinity chenyan-dfinity deleted the remove-dup branch October 23, 2023 21:09
@github-actions
Copy link

Benchmark for da48795

Click to view benchmark
Test Base PR %
Blob/&str 190.0±70.78µs 188.9±70.30µs -0.58%
Blob/ByteBuf 137.3±51.21µs 137.3±53.29µs 0.00%
Blob/Bytes 99.1±37.77µs 98.1±35.66µs -1.01%
Blob/String 207.5±77.26µs 209.5±77.90µs +0.96%
Collections/vec (text, nat) 63.2±0.80ms 63.0±0.75ms -0.32%
Collections/vec int 30.1±0.06ms 30.0±0.16ms -0.33%
Collections/vec int64 17.1±0.23ms 17.7±0.19ms +3.51%
Collections/vec nat8 13.3±0.08ms 13.5±0.05ms +1.50%
option list/1024 1329.3±2.85µs 1333.3±2.33µs +0.30%
profiles/1024 2.6±0.00ms 2.6±0.00ms 0.00%
variant list/1024 1114.5±3.71µs 1117.5±2.46µs +0.27%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants