Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove candid dependencies #485

Merged
merged 25 commits into from
Oct 27, 2023
Merged

Remove candid dependencies #485

merged 25 commits into from
Oct 27, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Oct 25, 2023

TODO

  • config pretty printer size
  • pass OptReport to deserializer
  • IDLValue::Blob
  • check with lalrpop version
  • Rust binding with i128/u128 config
  • parser for comment

@github-actions
Copy link

Benchmark for d8ec6ad

Click to view benchmark
Test Base PR %
Blob/&str 242.2±72.49µs 254.6±71.25µs +5.12%
Blob/ByteBuf 156.4±48.89µs 158.4±47.70µs +1.28%
Blob/Bytes 108.8±45.99µs 116.5±42.96µs +7.08%
Blob/String 315.1±152.24µs 326.2±154.09µs +3.52%
Collections/vec (text, nat) 71.5±1.43ms 70.6±1.23ms -1.26%
Collections/vec int 32.8±1.88ms 32.9±0.13ms +0.30%
Collections/vec int64 18.0±0.33ms 18.8±0.25ms +4.44%
Collections/vec nat8 14.3±0.12ms 14.6±0.04ms +2.10%
option list/1024 1390.5±5.00µs 1394.6±2.62µs +0.29%
profiles/1024 2.7±0.01ms 2.7±0.01ms 0.00%
variant list/1024 1130.1±13.85µs 1112.1±2.96µs -1.59%

@github-actions
Copy link

Benchmark for 10c046d

Click to view benchmark
Test Base PR %
Blob/&str 258.4±80.76µs 265.7±97.48µs +2.83%
Blob/ByteBuf 224.8±63.50µs 226.5±62.82µs +0.76%
Blob/Bytes 151.0±44.87µs 154.9±49.35µs +2.58%
Blob/String 321.1±92.08µs 319.9±94.05µs -0.37%
Collections/vec (text, nat) 86.0±3.99ms 84.4±4.01ms -1.86%
Collections/vec int 39.0±1.66ms 38.0±1.65ms -2.56%
Collections/vec int64 20.4±0.79ms 20.2±0.85ms -0.98%
Collections/vec nat8 15.7±0.45ms 15.8±0.51ms +0.64%
option list/1024 1712.3±57.87µs 1651.1±48.07µs -3.57%
profiles/1024 3.3±0.16ms 3.2±0.20ms -3.03%
variant list/1024 1328.3±46.09µs 1302.7±56.51µs -1.93%

@github-actions
Copy link

Benchmark for 6aefe72

Click to view benchmark
Test Base PR %
Blob/&str 271.1±102.99µs 264.3±89.11µs -2.51%
Blob/ByteBuf 240.5±76.26µs 224.0±61.53µs -6.86%
Blob/Bytes 147.2±45.85µs 163.8±52.99µs +11.28%
Blob/String 355.5±96.04µs 329.1±88.76µs -7.43%
Collections/vec (text, nat) 92.7±5.10ms 80.8±5.24ms -12.84%
Collections/vec int 39.4±1.96ms 36.9±1.83ms -6.35%
Collections/vec int64 22.7±1.41ms 21.3±1.25ms -6.17%
Collections/vec nat8 16.1±0.70ms 15.4±0.73ms -4.35%
option list/1024 1792.3±73.88µs 1618.9±86.88µs -9.67%
profiles/1024 3.5±0.21ms 3.2±0.22ms -8.57%
variant list/1024 1300.3±67.71µs 1268.6±101.68µs -2.44%

@github-actions
Copy link

Benchmark for 5f7b53d

Click to view benchmark
Test Base PR %
Blob/&str 240.3±72.20µs 241.7±71.54µs +0.58%
Blob/ByteBuf 153.3±50.18µs 152.9±49.11µs -0.26%
Blob/Bytes 107.1±44.68µs 109.6±44.54µs +2.33%
Blob/String 313.5±151.35µs 313.8±150.70µs +0.10%
Collections/vec (text, nat) 67.0±0.76ms 68.0±1.18ms +1.49%
Collections/vec int 32.3±0.07ms 32.2±0.08ms -0.31%
Collections/vec int64 17.8±0.30ms 18.8±0.30ms +5.62%
Collections/vec nat8 14.4±0.82ms 14.2±0.08ms -1.39%
option list/1024 1387.7±14.02µs 1389.7±6.75µs +0.14%
profiles/1024 2.7±0.08ms 2.8±0.06ms +3.70%
variant list/1024 1129.0±4.62µs 1111.5±3.98µs -1.55%

@github-actions
Copy link

Benchmark for bf5e597

Click to view benchmark
Test Base PR %
Blob/&str 262.3±82.86µs 288.3±91.25µs +9.91%
Blob/ByteBuf 234.1±74.75µs 223.2±61.68µs -4.66%
Blob/Bytes 158.2±60.52µs 143.4±40.57µs -9.36%
Blob/String 332.9±96.15µs 340.7±89.30µs +2.34%
Collections/vec (text, nat) 91.6±6.19ms 82.7±5.99ms -9.72%
Collections/vec int 39.2±1.94ms 38.4±2.38ms -2.04%
Collections/vec int64 21.7±1.54ms 21.5±1.60ms -0.92%
Collections/vec nat8 17.0±0.69ms 17.8±1.25ms +4.71%
option list/1024 1755.7±236.38µs 1682.0±116.39µs -4.20%
profiles/1024 3.2±0.31ms 3.4±0.17ms +6.25%
variant list/1024 1333.2±93.28µs 1212.1±88.11µs -9.08%

@github-actions
Copy link

Benchmark for bb7f236

Click to view benchmark
Test Base PR %
Blob/&str 293.2±88.43µs 291.4±88.47µs -0.61%
Blob/ByteBuf 217.5±66.03µs 216.3±59.10µs -0.55%
Blob/Bytes 126.9±36.20µs 131.1±39.31µs +3.31%
Blob/String 326.0±101.30µs 318.9±96.47µs -2.18%
Collections/vec (text, nat) 84.5±1.06ms 84.7±1.39ms +0.24%
Collections/vec int 39.0±0.10ms 38.9±0.16ms -0.26%
Collections/vec int64 24.0±1.06ms 22.4±0.32ms -6.67%
Collections/vec nat8 16.6±0.08ms 16.6±0.04ms 0.00%
option list/1024 1597.7±5.47µs 1600.7±6.84µs +0.19%
profiles/1024 3.2±0.01ms 3.5±0.16ms +9.38%
variant list/1024 1286.0±1.26µs 1290.9±2.16µs +0.38%

@chenyan-dfinity chenyan-dfinity merged commit b5316f9 into beta Oct 27, 2023
4 checks passed
@chenyan-dfinity chenyan-dfinity deleted the remove-dep branch October 27, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant