fix service_equal error reporting #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for baecaf3Click to view benchmark
|
rvanasa
approved these changes
Oct 26, 2023
chenyan-dfinity
added a commit
that referenced
this pull request
Oct 27, 2023
* remove num_enum * clean up parser dependencies * checkpoint * value feature * remove codespan * fix * fix * pretty * remove mute_warning * fix * pretty refactor * fix * reexport candid in parser * fix * fix * fix * bignum feature * bump candid_derive * silence subtyping in decoder * fix service_equal error reporting (#486) * add IDLValue::Blob * builder for config * fix * fix
chenyan-dfinity
added a commit
that referenced
this pull request
Oct 31, 2023
* fix service_equal error reporting (#486) * Add Arbitrary for Principal and extend random for Func * Use instead of * fmt * add arbitrary for principal --------- Co-authored-by: Yan Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_lengthshould compare label, not the whole item.