Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add nns list proposals benchmark #541

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Apr 8, 2024

This PR adds a benchmark for ListProposalInfoResponse.

@mraszyk mraszyk marked this pull request as draft April 8, 2024 08:18
Copy link

github-actions bot commented Apr 8, 2024

Name Max Mem (Kb) Encode Decode
blob 4_224 20_464_176 ($\textcolor{green}{-0.00\%}$) 12_084_214
btreemap 75_456 4_814_047_219 ($\textcolor{green}{-0.00\%}$) 15_380_666_953
nns 192 2_274_916 ($\textcolor{green}{-0.00\%}$) 14_317_956 ($\textcolor{green}{-0.16\%}$)
nns_list_proposal (new) 1_728 19_125_888 182_059_941
option_list 576 7_310_859 ($\textcolor{green}{-0.00\%}$) 33_834_131 ($\textcolor{green}{-0.07\%}$)
text 6_336 28_847_566 17_839_905
variant_list 128 7_518_554 ($\textcolor{green}{-0.00\%}$) 25_490_973
vec_int16 16_704 168_590_852 1_031_830_179
  • Parser cost: 18_351_038
  • Extra args: 3_353_048
Click to see raw report

---------------------------------------------------

Benchmark: blob
  total:
    instructions: 32.55 M (-0.00%) (change within noise threshold)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 20.46 M (-0.00%) (change within noise threshold)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 12.08 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: text
  total:
    instructions: 46.69 M (no change)
    heap_increase: 99 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 28.85 M (no change)
    heap_increase: 99 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 17.84 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: vec_int16
  total:
    instructions: 1.20 B (no change)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 168.59 M (no change)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 1.03 B (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: btreemap
  total:
    instructions: 20.19 B (-0.00%) (change within noise threshold)
    heap_increase: 1179 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 4.81 B (-0.00%) (change within noise threshold)
    heap_increase: 257 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 15.38 B (no change)
    heap_increase: 922 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: option_list
  total:
    instructions: 41.15 M (-0.05%) (change within noise threshold)
    heap_increase: 9 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 7.31 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 33.83 M (-0.07%) (change within noise threshold)
    heap_increase: 9 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: variant_list
  total:
    instructions: 33.01 M (-0.00%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 7.52 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 25.49 M (no change)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns
  total:
    instructions: 35.69 M (-0.06%) (change within noise threshold)
    heap_increase: 3 pages (no change)
    stable_memory_increase: 0 pages (no change)

  0. Parsing (scope):
    instructions: 18.35 M (no change)
    heap_increase: 3 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 2.27 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 14.32 M (-0.16%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns_list_proposal (new)
  total:
    instructions: 201.19 M (new)
    heap_increase: 27 pages (new)
    stable_memory_increase: 0 pages (new)

  1. Encoding (scope):
    instructions: 19.13 M (new)
    heap_increase: 6 pages (new)
    stable_memory_increase: 0 pages (new)

  2. Decoding (scope):
    instructions: 182.06 M (new)
    heap_increase: 21 pages (new)
    stable_memory_increase: 0 pages (new)

---------------------------------------------------

Benchmark: extra_args
  total:
    instructions: 3.35 M (no change)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------
Successfully persisted results to canbench_results.yml

Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this first. I have some hunch where to improve it.

@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review April 9, 2024 18:40
@chenyan-dfinity chenyan-dfinity merged commit 1f396d7 into master Apr 9, 2024
5 checks passed
@chenyan-dfinity chenyan-dfinity deleted the mraszyk/nns-proposals-bench branch April 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants