-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use btreemap for type_map and release #542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click to see raw report
|
rvanasa
approved these changes
Apr 11, 2024
chenyan-dfinity
changed the title
use btreemap for type_map
use btreemap for type_map and release
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking from the encoding flamegraph, with a large type table, the encoder spends a lot of time in
hashbrown::raw::RawTable::reserve_rehash
. Changing the data structure fromHashMap
toBTreeMap
significantly improves the performance. Another reason for the improvement is that comparing the type AST is usually cheaper than hashing the type AST.This PR also disables the memoization to unroll types. Type table can now be slightly larger, but saves a lot of time in encoding.
For
list_proposal
benchmark, encoding cost comes down from 19M to 10M. Further down to 6M after disabling type unrolling.