Skip to content

Commit

Permalink
Merge pull request #703 from dfinity/more-broken-links
Browse files Browse the repository at this point in the history
More broken links
  • Loading branch information
jessiemongeon1 authored Feb 2, 2024
2 parents a4172ff + ec7a189 commit 5e8aa09
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion motoko/ic-pos/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,4 +217,4 @@ Contributions are welcome! Please open an issue or submit a pull request.

## License

[MIT](./LICENSE)
[MIT](https://github.com/dfinity/examples/blob/master/motoko/ic-pos/LICENSE)
12 changes: 6 additions & 6 deletions motoko/invoice-canister/docs/bounty-task-checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ In addition to this, there's also a [Testing Glossary](TestingGlossay.md) showin
- [x] `clean-startup.mjs::disburse_funds_to_nnsFundedSecp256k1Identity_creator_subaccounts()` (lines [250](https://github.com/atengberg/examples/blob/ashton/invoice-bnt2/motoko/invoice-canister/clean-startup.mjs#L250)-270, 377).

- [x] **Adding the required ICRC1 token-ledger canister typings:**
[src/invoice/modules/supported-token/token-specific/icrc1/Types.mo](../../src/invoice/modules/supported-token/token-specific/icrc1/Types.mo)
[src/invoice/modules/supported-token/token-specific/icrc1/Types.mo](https://github.com/dfinity/examples/tree/master/motoko/invoice-canister/src/invoice/modules/supported-token/token-specific/icrc1/Types.mo)

- [x] **For consistency and integration adding an ICRC1 token-ledger canister actor supertype:**
[src/invoice/modules/supported-token/token-specific/icrc1/ActorSupertype.mo](../../src/invoice/modules/supported-token/token-specific/icrc1/ActorSupertype.mo)
[src/invoice/modules/supported-token/token-specific/icrc1/ActorSupertype.mo](https://github.com/dfinity/examples/tree/master/motoko/invoice-canister/src/invoice/modules/supported-token/token-specific/icrc1/ActorSupertype.mo)

- [x] **Adding the logic for ICRC1 addressing computations:**
- [x] [src/invoice/modules/supported-token/token-specific/icrc1/Adapter.mo](../../src/invoice/modules/supported-token/token-specific/icrc1/Adapter.mo)
- [x] [src/invoice/modules/supported-token/token-specific/icrc1/Adapter.mo](https://github.com/dfinity/examples/tree/master/motoko/invoice-canister/src/invoice/modules/supported-token/token-specific/icrc1/Adapter.mo)
- [x] `isValidSubaccount()`
- [x] `isValidAddress()`
- [x] `encodeAddress()`
Expand All @@ -46,7 +46,7 @@ In addition to this, there's also a [Testing Glossary](TestingGlossay.md) showin
`describe("ICRC1 Adapter Account and Subaccount Computations"...` (lines [270](https://github.com/atengberg/examples/blob/ashton/invoice-bnt2/motoko/invoice-canister/test/unit/Test.mo#L270)-422).

- [x] **Adding the logic connecting those addressing transformations to the invoice canister's API methods:**
- [x] [src/invoice/modules/supported-token/SupportedToken.mo](../../src/invoice/modules/supported-token/SupportedToken.mo).
- [x] [src/invoice/modules/supported-token/SupportedToken.mo](https://github.com/dfinity/examples/tree/master/motoko/invoice-canister/src/invoice/modules/supported-token/SupportedToken.mo).
_ㅤVariant tags mapping the two ICRC1 tokens:_
- [x] `SupportedToken<T1, T2>` (`#ICRC1_ExampleToken` & `#ICRC1_ExampleToken2` (lines [63](https://github.com/atengberg/examples/blob/ashton/invoice-bnt2/motoko/invoice-canister/src/invoice/modules/supported-token/SupportedToken.mo#L63)-64).
_ㅤRelated `SupportedToken`'s types each with corresponding ICRC1 type:_
Expand Down Expand Up @@ -77,7 +77,7 @@ In addition to this, there's also a [Testing Glossary](TestingGlossay.md) showin
_ㅤEach includes its own subsuite-set of test cases ("describe">"it") for each token type._
- [x] `describe("Supported Token Types' and Methods"...` (full set omitted here, lines [426](https://github.com/atengberg/examples/blob/ashton/invoice-bnt2/motoko/invoice-canister/test/unit/Test.mo#L426)-1651).

- [x] **Implementing the actual use of the above methods in the invoice canister's API methods in [src/invoice/Invoice.mo](../../src/invoice/Invoice.mo):**
- [x] **Implementing the actual use of the above methods in the invoice canister's API methods in [src/invoice/Invoice.mo](https://github.com/dfinity/examples/tree/master/motoko/invoice-canister/src/invoice/Invoice.mo):**
- [x] `create_invoice()`
- [x] `get_caller_address()`
- [x] `get_caller_balance()`
Expand Down Expand Up @@ -139,7 +139,7 @@ In addition to this, there's also a [Testing Glossary](TestingGlossay.md) showin
- [x] Add access control for creating new invoices (see [SEC-F20] & [SEC-F21] below).
- [x] Refactor permission checks to a method.
`src/invoice/Invoice.mo::getInvoiceIfAuthorized()` ([lines 100-142](https://github.com/atengberg/examples/blob/ashton/invoice-bnt2/motoko/invoice-canister/src/invoice/Invoice.mo#L100)).
- [x] Additionally, when first starting this bounty independently of any work I was doing, the startup scripting was being migrated to use zx which coincidentally at the time I had just become interested in. There's likely an ideal niche for dfx cli and zx for example in making dynamic canister deployment easier particularly as the javascript can console log out the arg as a literal without the explicit need of using it with zx. In any case as a result this migration was completed in the form of [`clean-startup.mjs`](../../clean-startup.mjs).
- [x] Additionally, when first starting this bounty independently of any work I was doing, the startup scripting was being migrated to use zx which coincidentally at the time I had just become interested in. There's likely an ideal niche for dfx cli and zx for example in making dynamic canister deployment easier particularly as the javascript can console log out the arg as a literal without the explicit need of using it with zx. In any case as a result this migration was completed in the form of [`clean-startup.mjs`](https://github.com/dfinity/examples/tree/master/clean-startup.mjs).

### Prevent arithmetic overflow when amount in TransferArgs is below 10_000 #35 ###
- [x] https://github.com/dfinity/invoice-canister/issues/35
Expand Down
2 changes: 1 addition & 1 deletion rust/vetkd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Additionally, the repository provides:

The frontend uses the [ic-vetkd-utils](https://github.com/dfinity/ic/tree/master/packages/ic-vetkd-utils) to create a transport key pair that is used to obtain a verifiably-encrypted key from the system API, to decrypt this key, and to derive a symmetric key to be used for AES encryption/decryption.

Because the `ic-vetkd-utils` are not yet published as NPM package at [npmjs.com](npmjs.com), a respective package file (`ic-vetkd-utils-0.1.0.tgz`) is included in this repository.
Because the `ic-vetkd-utils` are not yet published as NPM package at [npmjs.com](https://npmjs.com), a respective package file (`ic-vetkd-utils-0.1.0.tgz`) is included in this repository.

## Disclaimer

Expand Down

0 comments on commit 5e8aa09

Please sign in to comment.