Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default dfx version to 0.16.0 #645

Merged
merged 19 commits into from
Jan 29, 2024
Merged

Conversation

ericswanson-dfinity
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity commented Jan 26, 2024

This update to dfx 0.16.0 doesn't introduce any new test failures. It does change how some of them fail, since dfx 0.16.0 supports gzipped wasm, so the tests get farther.

The path filtering logic in the test workflows doesn't always work (skips some tests that should run based on what files changed in the PR), so I will follow up this PR with subsequent PRs to update individual tests to 0.16.0.

The changes to the motoko-invoice canister tests are:

  • give the workflows (e2e/unit) unique names so that they both show up in test results
  • make it so the workflow notices this error, rather than failing after 45 minutes due to 15s per-test timeouts:
(node:4971) UnhandledPromiseRejectionWarning: Error: Mismatch between expected canister id and current invoice canister id

@ericswanson-dfinity ericswanson-dfinity marked this pull request as ready for review January 26, 2024 20:35
@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner January 26, 2024 20:35
@ericswanson-dfinity ericswanson-dfinity merged commit 0d4bfb8 into master Jan 29, 2024
120 of 166 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the dfx-0.16.1-1 branch January 29, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants