chore: use dfinity/setup-dfx github action #708
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is to be compatible with dfxvm once it's released.
I also updated all of the workflows to use actions/checkout@v4. This PR is split into two commits: the first updates to actions/checkout@v4, the second updates to use dfinity/setup-dfx.
Requirements
These tests should install dfx now, and after dfxvm is released.
Considered Solutions
Another option would have been to copy the path setup from https://github.com/dfinity/setup-dfx/blob/main/action.yml into the provision scripts.
Recommended Solution
There's a github action now, so it seems nice to use it. Also the workflows used to use a couple different methods of overriding the dfx version. Now there's just one:
Considerations
This should reduce maintenance costs going forward, since https://github.com/dfinity/setup-dfx should be able to perform its part.