Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [VER-2721] rust/basic_dao #851

Merged
merged 15 commits into from
Apr 26, 2024
Merged

fix: [VER-2721] rust/basic_dao #851

merged 15 commits into from
Apr 26, 2024

Conversation

michael-weigelt
Copy link
Contributor

@michael-weigelt michael-weigelt commented Apr 24, 2024

This MR fixes the basic_dao examples.

@michael-weigelt michael-weigelt marked this pull request as ready for review April 24, 2024 16:31
@michael-weigelt michael-weigelt requested a review from a team as a code owner April 24, 2024 16:31
Michael Weigelt added 2 commits April 24, 2024 16:41
@ninegua
Copy link
Member

ninegua commented Apr 26, 2024

I had a look at the motoko invoice canister test failures:

  1. A canister id was hardcoded in the test, which is brittle. Recent dfx nns install would install more canisters, so the hardcoded canister id no longer matches. This can be temporarily fixed by hardcode the new correct canister id. But it will be better to have a more permanent fix.
  2. The motoko code uses Principal module to encode/decode extended text form of ICRC account, and this breaks in the recent motoko base lib because Principal would reject blobs longer than 32-byte. It requires a non-trivial fix that I don't think would suit this MR.

The rust-nft-wallet failures seem to be non-deterministic, as can be seen in these two runs: 8844360961 and 8844006204. I haven't looked too close yet.

@michael-weigelt michael-weigelt merged commit 2270eac into master Apr 26, 2024
128 of 131 checks passed
@michael-weigelt michael-weigelt deleted the mwe/fix_dao branch April 26, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants