chore: EXC: Fix potential overflows in priority deviation metric #2440
+25
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n` metric Also, fix potential overflows in other accumulated-priority calculations.
berestovskyy
changed the title
| @@ -408,7 +412,7 @@ impl RoundSchedule { | |||
|
|
|||
| // Compute the priority of the canisters for this round. | |||
| let mut accumulated_priority_invariant = AccumulatedPriority::default(); | |||
| let mut accumulated_priority_deviation = 0; | |||
| let mut accumulated_priority_deviation: i128 = 0; | |||
There was a problem hiding this comment.
Since all metrics end up as f64; and there's absolutely no need for this to be exceedingly precise; I'd just use f64. Then the code would be a lot simpler and there would be no need for saturating this or saturating that.
Comment on lines
+439
to
+440
| accumulated_priority_invariant = | ||
| accumulated_priority_invariant.saturating_add(&accumulated_priority); |
There was a problem hiding this comment.
While the saturating_add() may make sense for the variance (where you sum accumulated_priority^2), but we're never going to exceed u64 with realistic numbers of canisters and rounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fix potential overflows in other accumulated-priority calculations.