Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(IDX): move //rs/embedders:stable_grow_test to its own dedicated test and give it more CPUs #2452

Conversation

basvandijk
Copy link
Collaborator

@basvandijk basvandijk commented Nov 5, 2024

The //rs/embedders:embedders_integration_tests/stable_grow test often times out (at 5m) on CI when the runner is scheduled to a loaded node. The P90 at the time of writing is 4m 53s.

Let's move this test to a dedicated rust_ic_test and reserve a bit more CPUs to see if that reduces the overall parallelism and allows this test to run more quickly.

…test and give it more CPUs

The `//rs/embedders:embedders_integration_tests/stable_grow` test often
times out (at 5m) on CI when the runner is scheduled to a loaded
node. The P90 at the time of writing is 4m 53s.

Let's move this test to a dedicated rust_ic_test and reserve a bit
more CPUs to see if that reduces the overall parallelism and allows
this test to run more quickly.
@github-actions github-actions bot added the test label Nov 5, 2024
@basvandijk basvandijk marked this pull request as ready for review November 5, 2024 21:03
@basvandijk basvandijk requested a review from a team as a code owner November 5, 2024 21:03
@basvandijk
Copy link
Collaborator Author

Closed in favour of #2447.

@basvandijk basvandijk closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant