fix lints; persist canbench;

.github/workflows/validation.yaml

@@ -89,8 +89,6 @@ jobs:
   validate-node:
     name: 'validate-node:required'
     runs-on: ubuntu-latest
-    # disable until the frontend is ready
-    if: false
     steps:
       - name: 'Checkout'
         uses: actions/checkout@v4

apps/wallet/package.json

@@ -53,4 +53,4 @@
     "sass": "1.77.1",
     "vite-plugin-vuetify": "2.0.3"
   }
-}
+}

apps/wallet/src/components/accounts/wizard/AccountConfigurationSettings.vue

@@ -89,9 +89,7 @@ const model = computed({
 });
 
 const assetIds = computed({
-  get: () => props.modelValue.assets,
-  set: value => {
-    props.modelValue.assets = value;
-  },
+  get: () => model.value.assets,
+  set: value => (model.value.assets = value),
 });
 </script>

apps/wallet/src/components/inputs/TokenAutocomplete.vue

@@ -43,6 +43,8 @@ const input = withDefaults(
     readonly: false,
     disabled: false,
     rules: undefined,
+    excludedIds: undefined,
+    noDataText: undefined,
   },
 );
 

apps/wallet/src/pages/AccountAssetPage.vue

@@ -31,7 +31,7 @@
         </div>
         <PageHeader v-else :title="pageTitle" :breadcrumbs="pageBreadcrumbs">
           <template #subtitle>
-            <div v-for="accountAddress in addresses">
+            <div v-for="accountAddress in addresses" :key="accountAddress.address">
               <small
                 ><VChip
                   size="x-small"
@@ -57,38 +57,39 @@
           </template>
           <template v-if="asset" #actions>
             <BatchTransfersActionBtn
+              v-if="privileges.can_transfer"
               :account="account"
               variant="outlined"
               :asset="asset"
-              v-if="privileges.can_transfer"
             />
             <TransferBtn
+              v-if="privileges.can_transfer"
               :account="account"
               color="primary"
               :asset="asset"
-              v-if="privileges.can_transfer"
             >
               + {{ $t('pages.accounts.btn_new_transfer') }}
             </TransferBtn>
 
             <VMenu v-if="privileges.can_edit">
-              <template v-slot:activator="{ props }">
+              <template #activator="{ props: activatorProps }">
                 <VBtn
                   :icon="mdiDotsVertical"
                   color="primary-variant"
                   density="comfortable"
-                  v-bind="props"
+                  v-bind="activatorProps"
                 >
                 </VBtn>
               </template>
               <VList>
                 <VListItem
                   v-if="privileges.can_edit"
+                  :key="account.id"
                   color="primary"
                   variant="tonal"
                   link
-                  @click="removeAssetDialog = true"
                   :prepend-icon="mdiDelete"
+                  @click="removeAssetDialog = true"
                 >
                   <VListItemTitle>{{ $t('pages.account.remove_asset') }}</VListItemTitle>
                 </VListItem>
@@ -435,7 +436,7 @@ const loadAccount = async (): Promise<{
     .filter(account_address => formats.some(f => f.format == account_address.format))
     .map(account_address => ({
       address: account_address.address,
-      standard: formats.find(f => f.format === account_address.format)?.standard!,
+      standard: formats.find(f => f.format === account_address.format)!.standard,
       format: account_address.format,
       blockchain: maybeAsset.blockchain,
     }));

apps/wallet/src/pages/AccountPage.vue

@@ -97,7 +97,10 @@
                       </div>
                     </template>
                     <template #item.address="{ item: account_asset }">
-                      <div v-for="account_address in assetAddresses(account_asset.asset_id)">
+                      <div
+                        v-for="account_address in assetAddresses(account_asset.asset_id)"
+                        :key="account_address.address"
+                      >
                         <small>
                           <TextOverflow :max-length="32" :text="account_address.address">
                           </TextOverflow

apps/wallet/src/services/chains/index.ts

@@ -7,7 +7,7 @@ import { ICRC1Api } from './icrc1-api.service';
 export class ChainApiFactory {
   static create(asset: Asset, addresses: AccountAddress[]): ChainApi {
     switch (asset.blockchain) {
-      case BlockchainType.InternetComputer:
+      case BlockchainType.InternetComputer: {
         const maybeIcpNativeAddress = addresses.find(a => a.format === AddressFormat.ICPNative);
         const maybeIcrc1Address = addresses.find(a => a.format === AddressFormat.ICRC1);
         const maybeIndexCanisterId = getAssetMetadata(asset, 'index_canister_id');
@@ -29,6 +29,7 @@ export class ChainApiFactory {
         }
 
         throw new Error(`Blockchain not supported: ${asset.blockchain}`);
+      }
       case BlockchainType.Bitcoin:
       case BlockchainType.Ethereum:
       default:

core/station/impl/results.yml

@@ -1,55 +1,55 @@
 benches:
   batch_insert_100_requests:
     total:
-      instructions: 224426800
+      instructions: 228960691
       heap_increase: 0
       stable_memory_increase: 96
     scopes: {}
   find_100_users_from_50k_user_dataset:
     total:
-      instructions: 218785553
+      instructions: 218785601
       heap_increase: 97
       stable_memory_increase: 0
     scopes: {}
   find_500_external_canister_policies_from_50k_dataset:
     total:
-      instructions: 27420236
+      instructions: 27469607
       heap_increase: 0
       stable_memory_increase: 0
     scopes: {}
   heap_size_of_indexed_request_fields_cache_is_lt_300mib:
     total:
-      instructions: 130787905
-      heap_increase: 87
+      instructions: 193001574
+      heap_increase: 85
       stable_memory_increase: 0
     scopes: {}
   list_1k_requests:
     total:
-      instructions: 104112867
-      heap_increase: 7
+      instructions: 137301278
+      heap_increase: 14
       stable_memory_increase: 0
     scopes: {}
   list_external_canisters_with_all_statuses:
     total:
-      instructions: 201400896
+      instructions: 202075720
       heap_increase: 0
       stable_memory_increase: 0
     scopes: {}
   repository_find_1k_requests_from_10k_dataset_default_filters:
     total:
-      instructions: 92113388
+      instructions: 92109432
       heap_increase: 17
       stable_memory_increase: 0
     scopes: {}
   service_filter_5k_requests_from_100k_dataset:
     total:
-      instructions: 680224008
+      instructions: 681368127
       heap_increase: 106
       stable_memory_increase: 16
     scopes: {}
   service_find_all_requests_from_2k_dataset:
     total:
-      instructions: 275800951
+      instructions: 276820750
       heap_increase: 44
       stable_memory_increase: 16
     scopes: {}