Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): update frontend with new asset account data models #388

Merged
merged 23 commits into from
Oct 24, 2024
Merged

feat(wallet): update frontend with new asset account data models #388

merged 23 commits into from
Oct 24, 2024

Conversation

olaszakos
Copy link
Contributor

@olaszakos olaszakos commented Oct 15, 2024 •
edited
Loading

Todo:

  • add frontend tests
  • update locales
  • remove duplicated account name
  • make index canister optional and display a warning when transactions cannot be loaded if it's missing
  • fix icrc1 address shortening ...c0337e7f4d424...dec70df...
  • unify address display across the frontend
  • account page Requests button should filter for Accounts
  • fix notification error -- was local dev issue with unmigrated account
  • disallow removing an asset if any accounts reference it
  • localize assets page standards
  • fix edit account request views
  • restore ICP/ICRC1 asset creation custom form fields

POST MVP:

  • show fee at transfer
    • add icrc1/icp ledger interfaces to UI (dfx generate)
    • fetch when the dialog is displayed

@olaszakos olaszakos changed the base branch from main to multi-chain-support October 15, 2024 11:53
@olaszakos olaszakos marked this pull request as ready for review October 22, 2024 11:53
keplervital
keplervital approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@keplervital keplervital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work

apps/wallet/src/components/ShortenedAddress.vue Outdated Show resolved Hide resolved
apps/wallet/src/components/accounts/BatchTransfersActionBtn.vue Outdated Show resolved Hide resolved
apps/wallet/src/pages/AccountAssetPage.vue Outdated Show resolved Hide resolved
apps/wallet/src/utils/helper.utils.ts Outdated Show resolved Hide resolved
core/station/api/spec.did Outdated Show resolved Hide resolved
@olaszakos olaszakos merged commit ba10edc into multi-chain-support Oct 24, 2024
21 checks passed
@olaszakos olaszakos deleted the ORB-308-update-frontend-with-new-asset-account-data-modesl branch October 24, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keplervital keplervital keplervital approved these changes

@mraszyk mraszyk Awaiting requested review from mraszyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olaszakos @keplervital