Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to submit proposals using only quill #134

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Ability to submit proposals using only quill #134

wants to merge 8 commits into from

Conversation

jwiegley
Copy link
Contributor

@jwiegley jwiegley commented Sep 2, 2022

Description

This changes allows one to submit motion proposal directly using quill, rather than having to involve dfx. Usage:

quill neuron-manage <neuron-id> --proposal-title "<title>" --proposal-summary-file <summary file path>"

How Has This Been Tested?

I will test it tomorrow by submitting a motion proposal. Until then, this is marked draft.

Checklist:

  • I have made corresponding changes to the documentation in src/docs.

@jwiegley
Copy link
Contributor Author

jwiegley commented Sep 7, 2022

I've used this myself to submit a proposal.

@jwiegley jwiegley marked this pull request as ready for review September 7, 2022 00:07
@jwiegley jwiegley requested a review from a team as a code owner September 7, 2022 00:07
@jwiegley
Copy link
Contributor Author

jwiegley commented Sep 7, 2022

That Windows failure is going to make it impossible to test using proposal contents from a file via this CI.

sesi200
sesi200 previously approved these changes Sep 23, 2022
View reviewed changes
sesi200
sesi200 previously approved these changes Sep 23, 2022
View reviewed changes
ericswanson-dfinity
ericswanson-dfinity requested changes Sep 23, 2022
View reviewed changes
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have quill normalize newlines to \n format? Also, there are lint failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity requested changes

@sesi200 sesi200 sesi200 left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwiegley @sesi200 @ericswanson-dfinity